-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" #55656
Comments
LGTM |
lgtm |
@mkustermann go ahead and merge please. |
Closes #55529 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/364325 Cherry-pick-request: #55656 Change-Id: If352b8f2f2d09deb2805d4279177fb16941af873 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365580 Reviewed-by: Slava Egorov <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
@itsjustkevin The cherry-pick landed last week. That will ensure it will be included in the stable release for I/O, correct? If so, we can close this issue. |
We can close this issue @mkustermann. This cherry-pick missed the cutoff for the next release. If we create the cherry-pick again on top of the stable branch, we can get it in the first hotfix release. CC @kevmoo |
Filed a CP for |
Commit(s) to merge
54031e2
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/365580
Issue Description
Without this fix some apps run into crashes of the dart2wasm compiler, see #55529
What is the fix
The fix is to ensure synthetic functions created by CFE have default values for parameters where needed.
Why cherry-pick
We don't want customers to run into dart2wasm crashes in next stable branch.
Risk
If we run all CI tests on cherry-pick requests then risk is low. /cc @johnniwinther @chloestefantsova wdyt?
Issue link(s)
#55529
Extra Info
No response
The text was updated successfully, but these errors were encountered: