-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about cancel_subscriptions
#4950
Comments
I think that's intentional. Or a known limitation. In the latter example, we have a variable, such that we can track whether it is canceled. In the former example, we don't, so we throw our hands up. But I could see it being a false negative. |
Yeah, if it isn't assigned to a variable, and it isn't passed as an argument to an invocation, then I think we can conclude that it isn't cancelled. I don't know that I care deeply about it; I was just surprised when I discovered that it didn't get reported. (I was writing an example, and adding the variable creates an |
If you're not expecting errors, or is using |
Is it expected that the lint
cancel_subscriptions
does not generate a diagnostic for the following codebut will generate a diagnostic for the following code:
@pq @srawlins
The text was updated successfully, but these errors were encountered: