Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about PnP solutions #29

Open
uurbsrn4d opened this issue May 24, 2021 · 4 comments
Open

Questions about PnP solutions #29

uurbsrn4d opened this issue May 24, 2021 · 4 comments

Comments

@uurbsrn4d
Copy link

Hi @danini

I was trying your PNP/Ransac implementation for python. I had a few questions.

ss

It seems like opencv version ~50x faster. Is this expected because of the different pnp and ransac solutions used in methods or something is wrong ? By the way Pose solutions are nearly same for both versions.

My second question is are you planing to add other pnp methods such as SQPNP?

Thanks for your great work and sharing.

@danini
Copy link
Owner

danini commented Nov 18, 2021

Ah sorry for not answering earlier.
This definitely seems some problem, I will investigate it tomorrow.
I am planning on adding yes some other PnP solver since the current one, DLSPnP is not too reliable in my tests.

@uurbsrn4d
Copy link
Author

Is there any update on this issue?

@danini
Copy link
Owner

danini commented Mar 16, 2022

Actually, I have slightly more time than usual so I will look into this tomorrow and will, hopefully, solve it.

@danini
Copy link
Owner

danini commented Mar 17, 2022

I replaced all the solvers. It know works better than OpenCV on the example I tried.
https://github.com/danini/graph-cut-ransac/blob/master/examples/example_absolute_pose.ipynb

I still need to update the example since I added outliers artificially, but the algorithm should work and be fast now.
Let me know if there still is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants