Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running OAuth 2.0 Authorization Code workflow with local HTTPS server #31

Open
gdavison opened this issue Feb 7, 2021 · 2 comments · May be fixed by #38
Open

Allow running OAuth 2.0 Authorization Code workflow with local HTTPS server #31

gdavison opened this issue Feb 7, 2021 · 2 comments · May be fixed by #38
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gdavison
Copy link

gdavison commented Feb 7, 2021

The OAuth 2.0 Authorization Code workflow currently runs a local HTTP server to handle redirects. Some APIs, such as the Destiny API, do not allow HTTP redirect URLs to be configured.

A configuration option could be added to serve the redirect handler with HTTPS with a provided certificate, or restish could generate its own certificate.
@danielgtaylor danielgtaylor added enhancement New feature or request help wanted Extra attention is needed labels Apr 2, 2021
@danielgtaylor
Copy link
Owner

I'm willing to add this if someone wants to write the code 👍

@gdavison
Copy link
Author

gdavison commented Apr 2, 2021

I can write it up. I have a hacked-up version already, but it only does HTTPS now 😂 The config should be easy enough.

Design question: should each service potentially have its own certificates, or can they share a key? If shared, do they need to be stable, or generated if needed? Generated if needed seems like the simplest option, with an enhancement if specific certificates are needed for a service.

@gdavison gdavison linked a pull request Apr 5, 2021 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Optionally serve OAuth 2.0 authentication with HTTPS gdavison/restish
2 participants
@danielgtaylor @gdavison