Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify #3

Open
okonomiyaki3000 opened this issue Dec 4, 2015 · 1 comment
Open

Simplify #3

okonomiyaki3000 opened this issue Dec 4, 2015 · 1 comment

Comments

@okonomiyaki3000
Copy link

The size and color classes (``la-2x, la-3x`, `la-dark`, etc.) can (and should) be removed. These values should just come from the inherited `color` and `font-size` properties.

As it is, of course I can set the color to anything I like without relying on la-dark or la-light but this only works on the loader element itself.

works

<div class="la-ball-spin-clockwise my-custom-color-class">
    ...
</div>

doesn't work

<div class="loading-block-wrapper my-custom-color-class">
    <h2>Please wait a minute...</h2>
    <div class="la-ball-spin-clockwise">
        ...
    </div>
</div>

Sizing is a bigger issue because it's currently limited to the 4 sizes provided. In many cases it would be trivial to base the size of the loader elements on the inherited font size by using em. I can't say for sure that this would work with every animation in this library but, from what I've seen, it definitely works with some (probably most) of them.

@danielcardoso
Copy link
Owner

@okonomiyaki3000 thanks for comment.
I will check what you said in the next days and I will try to change the sizes classes :)

Once again thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants