Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint update strategy #562

Open
icecoffin opened this issue Jan 17, 2023 · 1 comment
Open

SwiftLint update strategy #562

icecoffin opened this issue Jan 17, 2023 · 1 comment

Comments

@icecoffin
Copy link

Currently the latest danger-swift-with-swiftlint Docker image is using SwiftLint 0.48.0 which was released in July 2022, so it's a couple of versions behind. This introduces some issues:

  • In our team, we try to keep the SwiftLint dependency up-to-date and move to the recent version when it comes out. This leads to a mismatch between the SwiftLint version we use locally and the one used by Danger Swift, which can cause some issues to be reported locally but not on CI (or vice versa).
  • We're currently experiencing an issue with a SwiftLint false positive that has been fixed in one of the latest releases, but the Danger plugin is still using the old one. So we don't experience this false positive locally, but it fails our CI check.

As far as I understand, bumping the SwiftLint version would require a new Danger Swift release. Would this alone be a good enough reason for a new release? If so, are we encouraged to do it?

@hlung
Copy link

hlung commented Jan 15, 2024

I'd love to see this fixed too. Maybe some workaround to allow pointing to a custom swiftlint binary, so that we don't have to require a new Danger Swift release. Or some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants