Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I get an error with no error message #10

Open
TurnrDev opened this issue Aug 22, 2020 · 3 comments
Open

I get an error with no error message #10

TurnrDev opened this issue Aug 22, 2020 · 3 comments

Comments

@TurnrDev
Copy link

Using danger-python-0.1.0 and [email protected] in CLI I get the following error:

(env) [jay@jay-arch DiscordBot]$ danger-python pr TrainerDex/DiscordBot#25
Starting Danger PR on TrainerDex/DiscordBot#25
You don't have a DANGER_GITHUB_API_TOKEN set up, this is optional, but TBH, you want to do this
Check out: http://danger.systems/js/guides/the_dangerfile.html#working-on-your-dangerfile
Usage: danger-python run [OPTIONS]
Try 'danger-python run --help' for help.

Error: no such option: -p

Danger: ⅹ Failing the build, there is 1 fail.

Failures

danger-python failed.

Markdowns

Log

I get the same issue in the GitHub action

@okainov
Copy link

okainov commented Apr 12, 2021

Still the same. It IS the error message: Error: no such option: -p. Coming from https://github.com/danger/python/blob/master/danger_python/shell.py#L30

But TBH when I first saw this repo, I was super excited... but when I looked in the code what do I see? That this just calls danger JS... SO what's the point?...

@orta
Copy link
Member

orta commented Apr 12, 2021

You can write your rules, and libraries in python - https://danger.systems/js/usage/danger-process.html

@marekargalas
Copy link

Hey! Any example how to get danger-python working? I got same error as above and can't figure it out. My GH actions example:

jobs:
  run-danger:
    name: "Run danger"
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@v3
      - name: Run command
        env:
          GITHUB_TOKEN: ${{ secrets.DANGER_GITHUB_API_TOKEN }}
        run: |
            npm install -g danger
            pip install danger-python
            danger-python ci

I got either Error: no such option: -p or Could not add a commit status, the GitHub token for Danger does not have access rights. even though it really creates a (blank) comment. Token is correct as with js danger everything works well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants