Not a Drone Pull Request - skipping danger run

[scottyab]

Report

What did you do?

Added the following to my Drone.yml in the default pipeline

 - name: run Danger PR validator
    image: dangersystems/danger-rb
    depends_on:
      - test
    commands:
      - bundle exec danger --fail-on-errors=true --new-comment --remove-previous-comments
    environment:
      DANGER_GITHUB_API_TOKEN:
        from_secret: DANGER_GITHUB_API_TOKEN
    when:
      event:
        include:
          - push
          - pull_request

What did you expect to happen?

Created a PR and expected Danger to run and analyse the Pull Request

What happened instead?

Console log from the " run Danger PR validator" Drone step

latest: Pulling from dangersystems/danger-rb
Digest: sha256: blahblahblah
Status: Downloaded newer image for dangersystems/danger-rb:latest
+ bundle exec danger --fail-on-errors=true --new-comment --remove-previous-comments
Not a Drone Pull Request - skipping `danger` run.

Your Environment

• Which CI are you running on? DroneCI

• Are you running the latest version of Danger? 8.6.1

• What is your Dangerfile?
  I'm just trying to get this hooked up to Drone so ATM my danger file is just

    warn("Hello from Danger :) ")

Thanks for the tool, its really useful, have successfully used it with Bitrise.io and this is my first time using with Drone.

[scottyab]

Hmmm... potentially this issue is on Drone or my setup of it. Seems DRONE_PULL_REQUEST is not being set, if hardcode the DRONE_PULL_REQUEST env var, danger will run aok.

environment
       # hardcoded the DRONE_PULL_REQUEST to get Danager to run
	DRONE_PULL_REQUEST: 1

[orta]

Perhaps drone doesn't set the same PR variables as before? I've never used Drone so it's kinda on you to figure this one I'm afraid

[scottyab]

Thanks @orta from the docs it seems DRONE_PULL_REQUEST is still valid, so I guess this must be more of a local issue with our setup?

As mentioned above if hardcode the DRONE_PULL_REQUEST Danger runs but it doesn't post to the actual PR I'm guessing as theDRONE_PULL_REQUEST is used elsewhere to actually post the messages. 🤔

[manicmaniac]

Not a Pull Request - skipping danger run is a common error when you run CI workflow before creating a pull request.

Please make sure your CI workflow runs after creating a pull request.