You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I created MR, Dangerbot posted a warning with a sticky flag according to my rule.
I fixed the problem.
What did you expect to happen?
The warning should be crossed out.
What happened instead?
The message with warning remained not updated, however the CI job with the Danger check passed.
Reproduction notes
I can reproduce this only if the warning was posted with a sticky flag, and it was the only warning remaining.
If there are other unfixed warnings, the outdated warning is crossed out.
classGit::Object::Commitdefsubjectself.message.lines.first.rstripenddeffixup?return/\bfixup!|\bsquash!/.match?(subject)endendifgit.commits.any? &:fixup?fail("Some fixup commits are still there.",sticky: true)end
Insights
I guess the problem happens because the case I described is simply not handled. edit_merge_request_note should also be called when there were old violations but no new violations.
AFAIS the same problem is present in GitHub plugin.
The text was updated successfully, but these errors were encountered:
Report
What did you do?
What did you expect to happen?
The warning should be crossed out.
What happened instead?
The message with warning remained not updated, however the CI job with the Danger check passed.
Reproduction notes
I can reproduce this only if the warning was posted with a sticky flag, and it was the only warning remaining.
If there are other unfixed warnings, the outdated warning is crossed out.
Your Environment
I use Gitlab CI
My Dangerfile
Insights
I guess the problem happens because the case I described is simply not handled.
edit_merge_request_note
should also be called when there were old violations but no new violations.AFAIS the same problem is present in GitHub plugin.
The text was updated successfully, but these errors were encountered: