New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for common ancestor #1442
Labels
Comments
This might be hard to do across all hosting platforms (as that usually lives in the API of github/gitlab etc) but you're welcome to try give it a shot on one or two if there's APIs you can find for it |
Normally danger runs without assuming a local deep clone git repo? |
It runs without assuming local access to git at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IIUC,
danger.git.base
ismaster
on localA common ancestor with base is useful to compare against the starting point of a PR.
For example, consider checking a change to an API being backwards compatible. In my PR, I'm adding a field
foo
which is a backward compatible change. It's possible that someone else has merged a change to the base branch adding fieldbar
. My PR is not removing fieldbar
but if I compare the two files naively, it would appear as if my PR removes fieldbar
.In terms of git, it's essentially the result of
git merge-base ${danger.git.head} ${danger.git.base}
.The text was updated successfully, but these errors were encountered: