Fix scrolling when wrapping is involved #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a wrapped display mode the current display is bugged. If some queries are wrapped before the line we put the focus on. It's possible that the said line is out of the screen. With this patch, the line with the focus is the always the first one. When a the focus is on a selected line, the text is now bold with a lighter brand of cyan. It is otherwise difficult to see if the first ligne of the display is selected since it always has the focus.
blogh
force-pushed
the
fix_scrolling_issues_4
branch
from
c87f831
to
bdb6f5c
Compare
|
There is something wrong when scrolling with arrows: the list of processes decreases until it gets restored when getting empty. |
dlax
reviewed
Dec 14, 2021
| @@ -996,7 +995,6 @@ PostgreSQL ... - test - [email protected]:.../tests - Ref.: 2s | |||
| Size: 106.07M - 0B/s ⋅ TPS: 0 ⋅ Active connections: 2 ⋅ Duration mode: query | |||
| RUNNING QUERIES | |||
| PID DATABASE state Query | |||
| ... tests idle in trans SELECT 43 | |||
There was a problem hiding this comment.
Why these changes in tests? Is it related to the scrolling issue mentioned in my other comment?
There was a problem hiding this comment.
yes, the line is outside the screen.
|
The active line is always on the top of the screen. |
|
Ah, I see, I missed that... I probably need to think more about the issue now. |
|
Replaced by #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a wrapped display mode the current display is bugged. If some
queries are wrapped before the line we put the focus on. It's possible
that the said line is out of the screen.
With this patch, the line with the focus is the always the first one.
When a the focus is on a selected line, the text is now bold with a
lighter brand of cyan. It is otherwise difficult to see if the first
ligne of the display is selected since it always has the focus.