Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Profile Social Links not saving #1133

Open
1 task done
kenn7575 opened this issue Apr 22, 2024 · 3 comments
Open
1 task done

馃悰 BUG: Profile Social Links not saving #1133

kenn7575 opened this issue Apr 22, 2024 · 3 comments

Comments

@kenn7575
Copy link

What went wrong? 馃

When trying to update and submit "Profile Social Links" on account page, the content isn't being saved correctly.

Expected Behavior

Being able to see the previous values types in the input fields when returning to the edit profile page.

Steps to Reproduce Issue

1. Go to '/account/profile'
2. Type value into 'Profile Social Links github'
3. Scroll down to 'summit changes'
4. Not being able to see the changes when returning to "/account/profile"

Solution Proposed

I don't if the data is being updated or if it's just a UX type of error, but it would make sense to see the values in their place as a confirmation that the data was saved.

Screenshots

No response

Environment

[MacBook, iPhone]

Browsers

Chrome, Safari

OS

Mac, iOS

Version of daily.dev

commit e80f215

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@idoshamun
Copy link
Member

We may have validation issue there, but for that we will need more information.
Feel free to send screenshot to support at daily.dev. I don't want you to share personal information here :)

@kenn7575
Copy link
Author

kenn7575 commented Apr 24, 2024

We may have validation issue there, but for that we will need more information. Feel free to send screenshot to support at daily.dev. I don't want you to share personal information here :)

I think I uncovered what the issue is. It was just the GitHub input that caused the validation to fail. It expects [userName] and I types "https://github.com/[userName]".

Maybe the site shouldn't redirect users if a validation error occurs. But instead, highlight the input with an error.

@idoshamun
Copy link
Member

You're right. We'll try to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants