Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references to CoTaskMemFree #34

Open
sclarke81 opened this issue Jan 25, 2019 · 2 comments
Open

Change references to CoTaskMemFree #34

sclarke81 opened this issue Jan 25, 2019 · 2 comments
Assignees

Comments

@sclarke81
Copy link

Would it be possible/worthwhile to update the references to CoTaskMemFree in the comments to say Marshal.FreeCoTaskMem?

@dahall
Copy link
Owner

dahall commented Jan 25, 2019

For the comments, I have largely left them exactly as they are in Microsoft's documentation. In fact, I have a tool that just scrapes it and pulls it into the comments. I could do a global search and replace on just 'CoTaskMemFree', but that could be wrong in places and then there are all the other replacements that I will have missed. Thoughts?

@sclarke81
Copy link
Author

Looking through the codebase I think all occurrences of CoTaskMemFree in comments could be replaced. Are you aware of any cases where it would be wrong?

Perhaps the substitution could be added to the scaper? If it's done generically then it can be used to deal with other replacements in the future.

@dahall dahall self-assigned this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants