Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Twitter to X #1193

Closed
vakesz opened this issue Aug 28, 2023 · 3 comments
Closed

Change Twitter to X #1193

vakesz opened this issue Aug 28, 2023 · 3 comments

Comments

@vakesz
Copy link

vakesz commented Aug 28, 2023

social-network-links.html:
https://github.com/daattali/beautiful-jekyll/blob/master/_includes/social-networks-links.html#L90

social-share.html
https://github.com/daattali/beautiful-jekyll/blob/master/_includes/social-share.html#L13

_config.yml
https://github.com/daattali/beautiful-jekyll/blob/master/_config.yml#L57

FontAwesome X Icon:
https://fontawesome.com/icons/x-twitter?f=brands&s=solid


Please only submit feature suggestions or bug reports if you believe something is broken.

If you need help, you can attend the Office Hours (only available for sponsors).

@vakesz vakesz changed the title Change twitter to X Change Twitter to X Aug 28, 2023
@daattali
Copy link
Owner

daattali commented Aug 28, 2023

This logo is not available in the fontawesome version that's used in beautifuljekyll right now. You can submit a PR, but you'd need to make sure that the UI of all existing logos doesn't change after upgrading FA

@daattali
Copy link
Owner

Updating to the latest fontawesome (6.4.2) should be fine because it's backwards compatible.

@daattali
Copy link
Owner

Done

sandordaroczi pushed a commit to sandordaroczi/sandordaroczi.github.io that referenced this issue Oct 16, 2024
adam-abed-abud pushed a commit to adam-abed-abud/old-adam-abed-abud.github.io that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants