Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop animation #3231

Closed
timscorbett opened this issue Mar 11, 2024 · 3 comments
Closed

Stop animation #3231

timscorbett opened this issue Mar 11, 2024 · 3 comments
Assignees
Labels
bug A bug in the code of Cytoscape.js
Milestone

Comments

@timscorbett
Copy link

Reported here
https://stackoverflow.com/questions/78130411/react-cytoscape-js-stop-animation

I forked an existing Cytoscape example to test playing and stopping an animation. Playing the animation works on "Add node" button, but stopping it fails to stop the animation without any error in the "Add relationship" button.

You will see an alert followed by

mySubCyRef.stop();
cy.current.stop();
https://codesandbox.io/p/sandbox/react-cytoscape-forked-jc6yky

What would work to stop all animations

(1) without resetting the layout
(2) maintaining the same styles as before the animation started?

@timscorbett timscorbett added the bug A bug in the code of Cytoscape.js label Mar 11, 2024
Copy link

stale bot commented Mar 30, 2024

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

@stale stale bot added the stale label Mar 30, 2024
@stale stale bot closed this as completed Apr 11, 2024
@mikekucera mikekucera removed the stale label Apr 17, 2024
@mikekucera mikekucera reopened this Apr 17, 2024
@mikekucera mikekucera added this to the 3.30.0 milestone May 16, 2024
@d2fong
Copy link
Member

d2fong commented May 16, 2024

Hi @timscorbett. I apologize for the cytoscape.js team's response to this issue. I will be working with you to help resolve it.

As a starting point, I need more clarity in how to reproduce your issue.

These are the first steps I think you are describing, can you correct me if I am wrong?

  1. Open your sandbox link
  2. Click the add node button

What should I do after that?

@mikekucera
Copy link
Contributor

I can't reproduce the issue with the example. Clicking "Add Relationship" stops the animation as expected.

If this issue continues to be a problem for you please reopen this bug with more details on how to reproduce the issue reliably.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the code of Cytoscape.js
Projects
None yet
Development

No branches or pull requests

4 participants