Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Address S101 violations in cyto_utils #392

Open
kenibrewer opened this issue Apr 2, 2024 · 0 comments
Open

[Refactor] Address S101 violations in cyto_utils #392

kenibrewer opened this issue Apr 2, 2024 · 0 comments
Labels
good first issue Good for newcomers refactor Improve codebase without changing functionality

Comments

@kenibrewer
Copy link
Member

#387 introduced Bandit checks. Several S101 violations in pycytominer.cyto_utils were left unaddressed at that time and were instead given # noqa: S101 ignores.

Acceptance Criteria:

  • There are no # noqa: S101 ignores in the pycytominer repo.
  • Pre-commit ruff checks are passing
  • Testing has been adjusted to expect the non-AssertionError error classes that will be created instead.
@kenibrewer kenibrewer added good first issue Good for newcomers refactor Improve codebase without changing functionality labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Improve codebase without changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant