misc: receive afterSpec durations from app capture code, and report them to the Cloud API #29500
Conversation
| @@ -289,6 +290,9 @@ export type ProtocolMetadata = ArtifactMetadata & { | |||
| size: number | |||
| offset: number | |||
| } | |||
| afterSpecDurations?: AfterSpecDurations & { | |||
There was a problem hiding this comment.
AfterSpecDurations is the shape that the protocol capture codebase will return; we're augmenting that with the total duration of afterSpec, so the shape is modified here.
2 flaky tests on run #55746 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
Review all test suite changes for PR #29500 ↗︎
Co-authored-by: Ryan Manuel <[email protected]>
| await this.invokeAsync('afterSpec', { isEssential: true }) | ||
| const startTime = performance.now() + performance.timeOrigin | ||
|
|
||
| debug({ startTime }) |
There was a problem hiding this comment.
Should we have a description here around what this is?
There was a problem hiding this comment.
I think this debug can be removed- the important debug is on L191
| fileSize: number | bigint | ||
| specAccess: ReturnType<AppCaptureProtocolInterface['getDbMetadata']> | ||
| } | undefined> { | ||
| async uploadCaptureArtifact ({ uploadUrl, fileSize, filePath }: CaptureArtifact, captureErrorsOverride?: boolean) { |
There was a problem hiding this comment.
Is captureErrorsOverride just used for testing purposes?
There was a problem hiding this comment.
Yep. Could refactor a bit to have caller pass in the env var to make things a little cleaner.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Because of the bifurcation of Test Replay capture/upload logic, the durations that are recorded in the afterSpec process will be returned from the protocol capture codebase' afterSpec method. They're collected and reported to the
updateInstanceArtifactsCloud API endpoint.Steps to test
Verify that, once the related services PR is merged and released, these durations are reported to the update instance artifacts endpoint when recording a spec with Test Replay enabled. When running against staging, these durations should be queryable in Honeycomb.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?