Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total refactoring #21

Open
antonkomarev opened this issue Mar 7, 2020 · 12 comments
Open

Total refactoring #21

antonkomarev opened this issue Mar 7, 2020 · 12 comments

Comments

@antonkomarev
Copy link
Member

This package requires total refactoring before adding new Laravel versions support and new features.

@minitia
Copy link

minitia commented Aug 6, 2020

hi @antonkomarev, what will it breaks if you remove the requirement of laravel 5?
Basically they are traits attached to models (I'm not expert in Laravel)
Thanks in advance

@antonkomarev
Copy link
Member Author

In theory L6 and L7 support could be added without removing L5 support.

@minitia
Copy link

minitia commented Aug 6, 2020

this in you composer
"illuminate/database": "~5.2|~5.3|~5.4|~5.5|~5.6|~5.7",
"illuminate/support": "~5.2|~5.3|~5.4|~5.5|~5.6|~5.7"
doesn't block laravel to v5?

I'm trying to install your branch add-latest-laravel-versions-support

@antonkomarev
Copy link
Member Author

Yes. I haven't added latest Laravel versions because this package was archived for a long time. You could send a PR for the new Laravel versions support.

@aaly00
Copy link

aaly00 commented Oct 11, 2020

@antonkomarev does the laravel7 branch work with laravel 7, or does the package still need to be updated to laravel7

@antonkomarev
Copy link
Member Author

This package is not working with latest laravel versions. I'm not using it on production anymore. It requires some refactoring.

@jny986
Copy link

jny986 commented Feb 15, 2021

Is this package still needed "Total Refactoring" to be an ongoing concern?
We are currently getting a "package is abandoned" message when installing the latest version.
I am happy to help put with the development that you are wanting to do if we can put together a plan of the development that is needed/wanted.
Thanks

@antonkomarev
Copy link
Member Author

@jny986 I've removed abandoned message. Package was updated at the end of the 2020, but I forgot to remove this notice.
I don't have plans to continue actively maintaining it by myself, but if you have an ideas how it could be improved - it's always opened for PRs.

@aaly00
Copy link

aaly00 commented Feb 15, 2021

I don't mind helping with the development as well.> Is this package still needed "Total Refactoring" to be an ongoing concern?

We are currently getting a "package is abandoned" message when installing the latest version.

I am happy to help put with the development that you are wanting to do if we can put together a plan of the development that is needed/wanted.

Thanks

@antonkomarev
Copy link
Member Author

antonkomarev commented Feb 15, 2021

@aaly00 not really, if you are fine with current implementation - we could continue development without changing its architecture and create separate package with the new one requirements when needed. It will be awesome if you will write how are you using this package and what you want to improve.

@andrekutianski
Copy link

This package requires total refactoring before adding new Laravel versions support and new features.

Supports Laravel 8/9?

@antonkomarev
Copy link
Member Author

@andrekutianski Laravel 8 is supported. You may provide a PR with Laravel 9 support if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants