Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out a common trait for stage2 plugins #521

Open
megri opened this issue Jun 14, 2017 · 1 comment
Open

Factor out a common trait for stage2 plugins #521

megri opened this issue Jun 14, 2017 · 1 comment

Comments

@megri
Copy link
Contributor

megri commented Jun 14, 2017

May do with a better name than stage2 too

@cvogt
Copy link
Owner

cvogt commented Jun 14, 2017

Let's not rename for now. stage2 symbolizes that this is the second stage of cbt's scala code during bootstrapping. On the package level, everything ends up in cbt. Happy to have a discussion about renaming suggestions though. So far I had imagined introducing one more stage for technical reasons, renaming nailgun_launcher to stageSomething and then renumbering them all 1-4 or 0-3. Maybe...

+100 for refactoring the compiler plugins. Maybe by moving the code that add compiler plugins into a ScalaBuild plugin trait ( into we can move some of the things in BaseBuild eventually as well ). And then having that trait maintain a list of plugins, all of which it simply enables, and you can add more. It probably needs to be a list of artifactId, groupId, version, resolverUrl, name. We can put the known ones into a list in the companion: ScalaBuild.plugins.
That's one way to do it. Any alternatives or thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants