-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation instructions are very much incomplete #270
Comments
I got an installation error using
|
Thanks for noting these issues.
We are no longer using
@kevinlkx I believe this is because it should be |
@pcarbo Can you also share the failure you experienced with |
This is the issue with Rfast:
CRAN strongly discourages such requirements because it many platforms by default do not support this requirement (that is, with standard system compilers). So my suggestion is to make it a "suggested" package, and add a strongly worded message if it is not being used to encourage people to install it (noting that computations can be very slow if it is not used). This is the approach we have taken in other packages such as susieR. |
@danielnachun Your new installation instructions aren't working for me:
|
I wasn't able to test this before in a totally clean system but now that I have I found a few different issues with the full source build. I'm working on the fixes now - not only did I specify the I'll work on making more packages optional or removing some dependencies all together:
|
@pcarbo I've now gotten everything to fully build from source using |
Thanks @danielnachun. I haven't fully checked that the installation works on my end, but it does look greatly improved. |
When I try to install pecotmr, I get this error:
These packages are not available on CRAN which is why the installation fails. I would recommend using the
Remotes:
inDESCRIPTION
to tellremotes::install_github
where to find these packages. See here for an illustration, and see here for details.Once you have updated your
DESCRIPTION
I can check that it works.Unrelated, I got a second installation error that is due to some installation difficulties with
Rfast
. I eventually got it working, but I'll note that the system requirements are quite stringent — Rfast will be quite difficult to install for many people. If you can make it an optional depenency, that would help a lot.The text was updated successfully, but these errors were encountered: