Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Across HTML Elements #13

Open
benjamin-chavez opened this issue Aug 2, 2023 · 0 comments
Open

Search Across HTML Elements #13

benjamin-chavez opened this issue Aug 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@benjamin-chavez
Copy link
Member

Currently the search and highlight functionality only works on strings that are in the same html element. However, these means that if we search abcdef on the following html, that the match wouldn't be found.

<span>
  <i>abc</i>def
</span>

Potential solutions:

  1. Update the search and highlight functionality to handle partial regex matches to allow us to continue searching past an elements closing tag.
  2. Replace all of the custom match logic with Mark.js
@benjamin-chavez benjamin-chavez added the bug Something isn't working label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant