Implement symdiff #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method names did not unambiguously specify behavior, so I've taken a guess: - matchedIndices is pairs of left, right indices - lhsRetained is pairs of out, left indices - rhsRetained is pairs of out, right indices
since only the matchedIndices and recoverLeft/recoverRight methods were used, those are the only ones that have been implemented. For simple transitive recover methods, with only 3 permutations of the types, the type arguments rotate amongst themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal implementation of SymDiff such that tensordot / multiplication can be implemented with backprop.
Note that this PR builds on top of the add-typelevel-tests branch - the actual commits are quite limited.