New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
count in days/years after 24h #287
Comments
Yep, this should be fixed, I'd accept a PR for this. Unfortunately I don't quite have the motivation to go through everything on a timely basis though, it is quite hard to find the motivation to keep working on this project. |
Understood. I might take a shot at this, so any idea you have from the top of your head on where to start would be appreciated! |
hugo has Math operations which are used in other parts of the code – you could try starting from that. |
Hi!
Is your feature request related to a problem? Please describe.
We have some long running outages, sometimes more than a day. An example of a catastrophic, week-long outage is this:
https://status.torproject.org/issues/2023-11-08-tor-weather-outage/
That says: "Resolved after 300h 5m of downtime". Now people strong in arithmetic will of course figure out that this is a little over a week and somewhat under two.
Describe the solution you'd like
Once we cross the 24h threshold, we should display intervals with days. For example, "300h 5m" should display as "12 days,10h 5m" here.
I guess that once you get past the 365 days mark, you might want to count in years too, but i am not sure anyone will reach that threshold.
But considering we actually use cstate to report on long-running "experiments" as well, that might actually really happen too! That's a local divergence from cstate that i'd like us to contribute back though, see our internal issue about this for more details and this component for an example. Update: opened #288 to discuss this.
Describe alternatives you've considered
I've long considered just not filing this bug and accepting the status quo, but I figured I might not be the only one finding this odd. :)
Additional context
Here's a screenshot of the outage report:
The text was updated successfully, but these errors were encountered: