Fixing incorrect logic when reducing to root test suite. Adding flags to allow for not reducing to root test suite. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow for not reducing to root test suite.
|
|
||
| if (allMatchingTestCasesToBeRun.Count == metaData.NrOfTestCasesInSuite) | ||
| if (allMatchingTestCasesToBeRun.All(_testCasesToRun.Contains) | ||
| && allMatchingTestCasesToBeRun.Count == _testCasesToRun.Count) |
There was a problem hiding this comment.
Now that I think about it, this still may not be strictly correct.
|
Hi and thanks for your PR! I currently do not have much time to work on GTA, but I will try to look into this on Sunday... |
|
Thanks for getting back to me @csoltenborn - no rush :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially resolves #330. This change fixed the problem I was facing, but it may not necessarily be correct for all cases. Will need to have a conversation about what the correct fix is. Making this PR to get that conversation started, and make the issue I created possibly make more sense.