Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add setting to consider reverted tests as failed in assertion mode #1248

Open
rappie opened this issue May 6, 2024 · 1 comment

Comments

@rappie
Copy link

rappie commented May 6, 2024

Describe the desired feature

I have switched to writing all my tests so that they should never revert. Currently I'm using additional self-tests to check my tests for unwanted reverts, it would be nice if this is a built-in option in Echidna.

Medusa has something similar:

				"panicCodeConfig": {
					"failOnCompilerInsertedPanic": false,
					"failOnAssertion": true,
					"failOnArithmeticUnderflow": false,
					"failOnDivideByZero": false,
					"failOnEnumTypeConversionOutOfBounds": false,
					"failOnIncorrectStorageAccess": false,
					"failOnPopEmptyArray": false,
					"failOnOutOfBoundsArrayAccess": false,
					"failOnAllocateTooMuchMemory": false,
					"failOnCallUninitializedVariable": false
				}

For my use case it would be enough to consider any revert as a failed test

@ggrieco-tob
Copy link
Member

One blocker here is that echidna will send ETH to non-payables functions from time to time, to cover some rare cases that the interface is incorrect (and increase coverage). These will most likely break this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants