From 36ffa22abde9d84705dfedc973b177a749f982dd Mon Sep 17 00:00:00 2001 From: Mrunal Kapade Date: Tue, 16 Aug 2016 16:44:46 -0700 Subject: [PATCH] Fix presubmit errors --- runtime/browser/printing/print_job_worker.cc | 1 - runtime/browser/printing/print_view_manager_base.cc | 6 +++--- runtime/browser/printing/printing_message_filter.h | 2 +- runtime/browser/xwalk_runner.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/runtime/browser/printing/print_job_worker.cc b/runtime/browser/printing/print_job_worker.cc index 39d77fcba5..a65362128f 100644 --- a/runtime/browser/printing/print_job_worker.cc +++ b/runtime/browser/printing/print_job_worker.cc @@ -14,7 +14,6 @@ #include "base/thread_task_runner_handle.h" #include "base/values.h" #include "build/build_config.h" -//#include "chrome/grit/generated_resources.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/render_view_host.h" diff --git a/runtime/browser/printing/print_view_manager_base.cc b/runtime/browser/printing/print_view_manager_base.cc index b82c031b5b..0240b75752 100644 --- a/runtime/browser/printing/print_view_manager_base.cc +++ b/runtime/browser/printing/print_view_manager_base.cc @@ -190,8 +190,8 @@ void PrintViewManagerBase::OnPrintingFailed(int cookie) { } void PrintViewManagerBase::OnShowInvalidPrinterSettingsError() { - LOG(ERROR) << "The selected printer is not available or not installed \ - correctly."; + LOG(ERROR) << "The selected printer is not available or not installed" + " correctly."; } void PrintViewManagerBase::DidStartLoading() { @@ -493,7 +493,7 @@ void PrintViewManagerBase::ReleasePrinterQuery() { int cookie = cookie_; cookie_ = 0; - PrintJobManager* print_job_manager = + PrintJobManager* print_job_manager = XWalkRunner::GetInstance()->print_job_manager(); // May be NULL in tests. if (!print_job_manager) diff --git a/runtime/browser/printing/printing_message_filter.h b/runtime/browser/printing/printing_message_filter.h index 980db1389b..cd1b05c99b 100644 --- a/runtime/browser/printing/printing_message_filter.h +++ b/runtime/browser/printing/printing_message_filter.h @@ -42,7 +42,7 @@ class PrinterQuery; // renderer process on the IPC thread. class PrintingMessageFilter : public content::BrowserMessageFilter { public: - PrintingMessageFilter(int render_process_id); + explicit PrintingMessageFilter(int render_process_id); // content::BrowserMessageFilter methods. void OverrideThreadForMessage(const IPC::Message& message, diff --git a/runtime/browser/xwalk_runner.h b/runtime/browser/xwalk_runner.h index f78daed4a5..0c733e9467 100644 --- a/runtime/browser/xwalk_runner.h +++ b/runtime/browser/xwalk_runner.h @@ -151,7 +151,7 @@ class XWalkRunner { // Remote debugger server. std::unique_ptr remote_debugging_server_; - // Ensures that all the print jobs are finished before closing + // Ensures that all the print jobs are finished before closing std::unique_ptr print_job_manager_; DISALLOW_COPY_AND_ASSIGN(XWalkRunner);