Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFP: CNI GC, STATUS support #8018

Open
squeed opened this issue Apr 15, 2024 · 5 comments
Open

CFP: CNI GC, STATUS support #8018

squeed opened this issue Apr 15, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@squeed
Copy link
Contributor

squeed commented Apr 15, 2024

CNI v1.1, which just released, includes two new verbs. It would be nice if CRI-O included support for them.

The verb STATUS allows for a plugin to indicate readiness to accept ADD requests. This takes the place of the awkward "let me remove my network configuration file because I'm upgrading" dance. It's all much cleaner. cri-o should "delegate" the Status CRI request to the CNI plugin(s).

The verb GC is a way for the runtime to pass a list of known-valid sandboxes to the CNI plugin. The CNI plugin can then clean up stale resources, such as leaked IPAM records. This will have to be invoked by cri-o based on some timer, as it is not directly related to a CRI API call.

I'm happy to start work on this, especially for STATUS. I'm not familiar enough with the cri-o code to immediately attack GC, but I'm happy to help provide guidance.

@sohankunkerkar sohankunkerkar added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 15, 2024
@squeed
Copy link
Contributor Author

squeed commented Apr 16, 2024

cri-o/ocicni#196 adds STATUS support to ocicni.

I'll see about GC support.

@squeed
Copy link
Contributor Author

squeed commented Apr 16, 2024

I should have a PR for ocicni GC support shortly. I'll need a bit of help folding it in to cri-o.

@squeed
Copy link
Contributor Author

squeed commented May 6, 2024

@jcaamano has agreed to take a look at this :-)

@squeed
Copy link
Contributor Author

squeed commented May 6, 2024

An update: STATUS will require no work besides bumping ocicni. GC will be a lot trickier :-)

@saschagrunert
Copy link
Member

OCI CNI v0.4.3 should have the feature available now: https://github.com/cri-o/ocicni/releases/tag/v0.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: To do
Development

No branches or pull requests

3 participants