Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] factor out darkMode( el ) #325

Open
liemteksun opened this issue Dec 8, 2021 · 1 comment
Open

[Feature Request] factor out darkMode( el ) #325

liemteksun opened this issue Dec 8, 2021 · 1 comment

Comments

@liemteksun
Copy link

What is your enhancement?

Can you factor out function darkMode(el)?

I don't use "Material UI Configurator" side bar - I use my own page to let the user configures the color & dark mode

I suggest adding a function darkMode( boolean ), which will be called by darkMode(el)
Essentially, darkMode(el) will be something like

function darkMode(el)
{
   if ( !el.getAttribute("checked") )
   {
      darkMode( true );
      el.setAttribute("checked", "true");
   }
   else
   {
      darkMode( false );
      el.removeAttribute("checked");
   }
}

thanks

@rarestoma
Copy link

Hi @liemteksun,

Thank you for working with our products.

I just added this requirement to be discussed for the next update.

Best regards,
Rares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants