Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] onkeyup can't be used #322

Open
liemteksun opened this issue Nov 11, 2021 · 3 comments
Open

[Bug] onkeyup can't be used #322

liemteksun opened this issue Nov 11, 2021 · 3 comments

Comments

@liemteksun
Copy link

liemteksun commented Nov 11, 2021

Version

3.0.1

Reproduction link

https://osplit.com/s/material-dashboard-pro-html-v3.0.1/pages/ecommerce/products/keyup.html

Operating System

Linux

Device

Chrome

Browser & Version

Chrome 94

Steps to reproduce

If you type something on the name input field, there won't be anything on the javascript console ( even when I have this code on the input field - onkeyup="console.log('key up')" )

Removing
<script src="../../../assets/js/material-dashboard.min.js?v=3.0.1"></script>
makes the onkeyup to work again

I think this has to do with my other issue (#317)

On material dashboard v 2.1.2, I can use onkeyup, but now I couldn't

I hope solving issue #317 will solve this as well

What is expected?

onkeyup binding to work

What is actually happening?

the 'onkeyup' is attached to this function

inputs[i].onkeyup = function(e) {
  if (this.value != "") {
    this.parentElement.classList.add('is-filled');
  } else {
    this.parentElement.classList.remove('is-filled');
  }
};

Solution

Additional comments

@groovemen
Copy link
Contributor

Hello @liemteksun,

Sorry for this late response, I have added this issue to be solved into the next product update.
All the best,
Stefan

@liemteksun
Copy link
Author

I appreciate the update
thanks

@liemteksun
Copy link
Author

I see that there are 2 minor releases since I open this issue, but I still can't use the onkeyup - when is this going to make it to the release?
I think most of my bugs are not in the new release yet :(

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants