-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'tag' works beautifully when applied to the root of profile but produces warning #256
Comments
Hi, The reason it's not a tag expected on the profile configuration is because it's not a flag for some commands. All the flags at the root would be applied to any command. I suppose we could support it, and it would only be applied to the commands that accept the flag. I can't guarantee we will support it though: it depends on how more complex it's going to make the compilation into flags. It's already getting quite complicated 😉 I guess you can still use it, but be aware that it might break in the future. Also we have no test covering this case 👍🏻 |
Based on what we documented "Most supported flags can be set in this way at profile level" (https://creativeprojects.github.io/resticprofile/configuration/inheritance/index.html#common-flags) .. I think we should support it for all common flags (including In-deed a test (and a fix for the warnings) is missing. |
If using root-level tag I get one of these two warnings depending on whether its applied as list or single key-value
Note that restic is correctly invoked with the tag, even when applied to the root profile. This goes for both backup (+auto forget with
retention:
after backup), snapshot and forget (those are what I have tested)I know I can apply the tag to backup, but if I do that, then tag isn't applied to snapshot, and I have to duplicate it. I guess it can make sense to have a tag only on backup and not on snapshots, if using multiple tags but for me it seems I just want one tag to identify the backup. If I apply an outer and an inner tag, the outer tag is lost, but that seems to be the standard way for inheritance as well, so that makes sense (well except for backup.verbose: 0, which is ignored instead of overwritten root, but I'm sure that's another thing).
Is this intended?
I notice the docs do not mention tag in the root of profile. Is that something I should avoid because it might break in the future, as its 'unsupported'?
I'm using yaml version 2, and
The text was updated successfully, but these errors were encountered: