Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/image search added | User can search images directly from the page/post editor Window. #107

Conversation

Rajesh-Royal
Copy link
Contributor

Fixes

Fixes #106

Description

User can search cc-licensed images directly from the post/page editor window. This code uses Iframe.

Technical details

  • Added image-search-creativecommon.php file in /include folder
  • Added asset folder in /include directory It contains script and style files.
  • Import the image-search-creativecommon.php file in main creativecommons.php file.

Tests

  1. click on "insert cc license image" button
  2. search for an image in the model window.
  3. Choose Image copy HTML code and paste in editor.
  4. Support classic editor only.

Screenshots

  1. Editor button
    image 1

  2. Onclick "Insert cc license image" button and search
    image 2

  3. Onclick single image | copy code from attribute tab
    image 3

  4. Result
    image 4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Rajesh-Royal Rajesh-Royal requested a review from a team as a code owner April 5, 2020 17:05
@Rajesh-Royal Rajesh-Royal requested a review from a team April 5, 2020 17:05
@kgodey kgodey requested a review from hugosolar April 6, 2020 16:41
Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Personally I'm not in favor of embedding things as a solution. Also, I think it's a little bit confusing in terms of UX.
I would prefer an integration with the CC Catalog API as you propose on the open ticket

@Rajesh-Royal Rajesh-Royal deleted the feature/image-search-added branch April 14, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cc-image search feature in plugin
2 participants