Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required define #58

Open
rafzi opened this issue Nov 12, 2020 · 6 comments
Open

Update required define #58

rafzi opened this issue Nov 12, 2020 · 6 comments

Comments

@rafzi
Copy link
Collaborator

rafzi commented Nov 12, 2020

From SIGMICRO list:

If you explicitly have TF_LITE_STATIC_MEMORY defined in a Make or build config, please update that build define to TF_LITE_MICRO.

@cpetig
Copy link
Owner

cpetig commented Nov 14, 2020

Hi Rafael, do you have a more specific link? I was unable to find it at https://gitter.im/tensorflow/sig-micro . I would like to understand which tf versions are affected how.

@cpetig
Copy link
Owner

cpetig commented Nov 14, 2020

I see tensorflow/lite/micro/tools/make/Makefile in r2.4 still define TF_LITE_STATIC_MEMORY and I see no usage of a TF_LITE_MICRO in r2.4 (as of today)

@rafzi
Copy link
Collaborator Author

rafzi commented Nov 14, 2020

I just copied from inbox to issue, but you are right that there seems to be no mention of this flag in the official repo.

https://groups.google.com/a/tensorflow.org/g/micro/c/ExZmKoRzeAs

@cpetig
Copy link
Owner

cpetig commented Nov 14, 2020

That sounds like r2.5 material (also given the time it got posted (after releasing 2.4-rc2)), so I believe it won't affect us for another months (till we create a r2.5 branch).
By the way would you agree to remove the branch master from the repository? Besides the obvious issues with the name I think it adds more confusion than it helps. Especially since I created r2.1..r2.4 and made r2.3 the default branch some time ago.

@rafzi
Copy link
Collaborator Author

rafzi commented Nov 16, 2020

The master branch still serves a purpose for me, in that I'd use it to keep up with tensorflow master. However we could rename it to "develop"/"dev" to avoid confusion.

@cpetig
Copy link
Owner

cpetig commented Dec 9, 2020

Today I found the info that this rename got delayed: https://groups.google.com/a/tensorflow.org/g/micro/c/ExZmKoRzeAs/m/XoemFLMgAAAJ?pli=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants