-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded video does not respect the media_subpath Front Matter variable #1738
Comments
🎉 This issue has been resolved in version 7.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks for the fix! |
Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
How did you create the site?
Generated from
chirpy-starter
Describe the bug
When you embed a video using the include statement as follows:
the code ignores the media_subpath variable, looks for the mp4 file in the root of the project instead of where the media_subpath folder is pointing to.
Steps To Reproduce
Create a page and include the video.html file as above...set put the video in say /assets/posts/videos and set the media_subpath Front Matter page variable to that...
Expected Behavior
All media should be relative to the media_subpath variable, images and video ( and their posters).
In the file /_includes/embed/video.html, lines 6 thru 10 are as follows.
It appears they should be...
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: