Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: iavl/v2 logger is distinct from app logger #23326

Open
1 task done
julienrbrt opened this issue Jan 10, 2025 · 0 comments
Open
1 task done

[Bug]: iavl/v2 logger is distinct from app logger #23326

julienrbrt opened this issue Jan 10, 2025 · 0 comments
Assignees
@julienrbrt
Labels
C:Store T:Bug

Comments

@julienrbrt
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Looks like the iavl/v2 logger is not inherited from the app: https://github.com/cosmos/iavl/blob/master/v2/tree.go#L17-L20
Meaning, it doesn't respect any of the app flags and has a different format:

Image

We should update iavl v2 to use a logger like v1 does, and pass it from store/v2

Cosmos SDK Version

v2

How to reproduce?

No response
@julienrbrt julienrbrt self-assigned this Jan 10, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Jan 10, 2025
@julienrbrt julienrbrt moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jan 10, 2025
@julienrbrt julienrbrt mentioned this issue Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
C:Store T:Bug
Projects
Cosmos-SDK
Status: 🤸‍♂️ In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julienrbrt