Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Swagger support in server/v2? #23020

Open
julienrbrt opened this issue Dec 19, 2024 · 2 comments
Open

Default Swagger support in server/v2? #23020

julienrbrt opened this issue Dec 19, 2024 · 2 comments
Labels
C:server/v2 Issues related to server/v2

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Dec 19, 2024

Noticed while doing #23018 that server/v2 doesn't server a swagger UI.
Is that something server/v2 should support out of the box?

The server in v1 is fairly simple: https://github.com/cosmos/cosmos-sdk/blob/d297747/server/swagger.go, hence super easily to add by chain themselves with the UI they prefer.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Dec 19, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 19, 2024
@julienrbrt julienrbrt added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels Dec 19, 2024
@julienrbrt julienrbrt changed the title Swagger in server/v2 or not? Default Swagger support in server/v2? Dec 19, 2024
@julienrbrt
Copy link
Member Author

If we agree on not adding it, I can mention this in the v2 docs: #22531

However, we could easily create a server/v2/api/swagger if that's something we still want to support out of the box.

My two cents would say we do not need that, and that less is more in that case.

@tac0turtle
Copy link
Member

It matters how grpc-gateway will work, right now its generated from there tooling but if we remove the tooling then would it work the same way with generation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants