Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmasked S-Box - Unassigned signal in module GF_Inv_4 #1

Open
lea-micheloud opened this issue Dec 19, 2020 · 0 comments
Open

Unmasked S-Box - Unassigned signal in module GF_Inv_4 #1

lea-micheloud opened this issue Dec 19, 2020 · 0 comments

Comments

@lea-micheloud
Copy link

Hello !
I believe the unmasked version of your AES Sbox is missing a signal assignment : on line 74-76, you do the following
assign sd = d[1] ^ d[0];
GF_MULS_2 pmul(d, sd, b, sb, p);
GF_MULS_2 qmul(d, sd, a, sa, q);
but due to the optimization you added the signal d is no longer assigned. I made it work by simply adding
assign d = {c[0], c[1]};
but I trust you might have a more elegant solution.
All the best !
P.S. : thanks for your work, it has been really enjoyable and instructive to read :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant