Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes text from overflowing in select menu dropdowns #7792

Merged
merged 2 commits into from
May 14, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

Before

image

After

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner May 10, 2024 12:59
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 1:02pm

Copy link

netlify bot commented May 10, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1de2999
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/663e1a45f939fe0008c28147
😎 Deploy Preview https://deploy-preview-7792--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 10, 2024

Passing run #2501 ↗︎

0 123 0 0 Flakiness 0

Details:

Fixes text from overflowing in select menu dropdowns
Project: CARE Commit: 1de2999c6b
Status: Passed Duration: 03:03 💡
Started: May 10, 2024 1:04 PM Ended: May 10, 2024 1:08 PM

Review all test suite changes for PR #7792 ↗︎

@nihal467 nihal467 added P1 breaking issue or vital feature P2 and removed P1 breaking issue or vital feature labels May 10, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2f2c6a0 into develop May 14, 2024
65 checks passed
@khavinshankar khavinshankar deleted the issues/7790/fix-responsiveness-of-selectmenuv2 branch May 14, 2024 22:44
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the local body field in the patient registration form is not properly responsive
3 participants