Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block expired patients from being transfered #8123

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Block expired patients from being transfered #8123

merged 9 commits into from
Jul 17, 2024

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Jul 8, 2024 •
edited

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team as a code owner July 8, 2024 09:54
@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 3:23pm

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 211602f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6697e1a47303eb00088b86ca
😎 Deploy Preview https://deploy-preview-8123--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar added needs testing needs review P1 breaking issue or vital feature labels Jul 8, 2024
@cypress Cypress
Copy link

cypress bot commented Jul 8, 2024 •
edited

Passing run #2896 ↗︎

0 126 0 0 Flakiness 0

Details:

Block expired patients from being transfered
Project: CARE Commit: 211602f56a
Status: Passed Duration: 02:53 💡
Started: Jul 17, 2024 3:27 PM Ended: Jul 17, 2024 3:30 PM

Review all test suite changes for PR #8123 ↗︎

rithviknishad
rithviknishad approved these changes Jul 8, 2024
View reviewed changes
src/Components/Facility/DischargeModal.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Jul 9, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

@khavinshankar
image
image

in the patient transfer form, dropdown, as per issue, it should mention expired, and greyed out

@khavinshankar
Copy link
Member Author

@nihal467 added expired near the option
image

Please check.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 16, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Jul 16, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit f4036e9
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/6696a5c3d63c0a0008adbbb2

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jul 16, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Jul 16, 2024
@nihal467 nihal467 added urgent Cypress Test Pending The Cypress test are to be verified and removed waiting for backend labels Jul 17, 2024
@nihal467 nihal467 removed the Cypress Test Pending The Cypress test are to be verified label Jul 17, 2024
@nihal467
Copy link
Member

@gigincg can you review and merge it

@gigincg gigincg merged commit 629ae0f into develop Jul 17, 2024
63 checks passed
@gigincg gigincg deleted the fix-6022 branch July 17, 2024 17:01
@github-actions GitHub Actions
Copy link

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@nihal467 nihal467 nihal467 approved these changes

Assignees
No one assigned
Labels
P1 breaking issue or vital feature reviewed reviewed by a core member tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marking Death on patient profile
4 participants
@khavinshankar @nihal467 @gigincg @rithviknishad