Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of duplicate symptoms if cure date is present #8002

Open
nihal467 opened this issue Jun 8, 2024 · 4 comments · May be fixed by coronasafe/care#2289
Open

Allow creation of duplicate symptoms if cure date is present #8002

nihal467 opened this issue Jun 8, 2024 · 4 comments · May be fixed by coronasafe/care#2289
Assignees
Labels

Comments

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2024

Describe the bug

Currently, the symptoms dropdown shows symptoms that are already added to the list, which can create a duplicate record for the same symptoms

To Reproduce
Steps to reproduce the behavior:

  1. Go to create consultation
  2. add a symptoms and search for the same in the list
  3. See error

Expected behavior

hide already added symptoms from the dropdown

Screenshots

image

@nihal467 nihal467 added the P1 breaking issue or vital feature label Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@rithviknishad
Copy link
Member

rithviknishad commented Jun 9, 2024

@nihal467 this is expected behaviour if the existing symptom is already cured (has cure date). So that the same symptom can be started with a new onset date.

image

@rithviknishad rithviknishad added question Further information is requested discussion required and removed P1 breaking issue or vital feature labels Jun 9, 2024
@nihal467
Copy link
Member Author

image

  • In the frontend, when a symptom is marked as cured, the same symptom can be added again to the list while creating a consultation. This will throw an error: "Create symptoms - duplicate symptoms are not allowed," since the backend only checks if all symptoms are unique or not.

@aparnacoronasafe

  1. should we allow user to input date of cure while creating a consultation
  2. once a date of cure is added, should we allow user to add a existing symptoms with cure date to the same list during create consultation

@aparnacoronasafe
Copy link
Member

  1. Yes. While creating consultation say on 1st June, they may want to note that the patient has symptom XYZ from 20-30th May.

  2. Yes. In the above eg, the user may want to add symptom xyz from 20-30th May, and then again same symptom from 31st May to 2nd June, Or 31st May - ongoing with no cure date

@nihal467 nihal467 removed question Further information is requested discussion required labels Jun 18, 2024
@rithviknishad rithviknishad changed the title Hide already added symptoms from the dropdown Allow creation of duplicate symptoms if cure date is present Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

3 participants