Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prescriptions: Default Discontinued Prescriptions Collapsed #7767

Closed
gigincg opened this issue May 7, 2024 · 6 comments · Fixed by #7833
Closed

Prescriptions: Default Discontinued Prescriptions Collapsed #7767

gigincg opened this issue May 7, 2024 · 6 comments · Fixed by #7833
Assignees
@rithviknishad @Sulochan-khadka
Labels
good first issue Good for newcomers Prescriptions / Medicines Related to prescriptions or medicines module.

Comments

@gigincg
Copy link
Member

gigincg commented May 7, 2024

When there are multiple discontinued prescriptions for a patient, looking at the ones that are prescribed becomes difficult. Since they are not editable, having a collapsed view for prescriptions, and defaulting all discontinued prescriptions as collapsed would considerably improve

Ref Screenshot:
image
@gigincg gigincg added the good first issue Good for newcomers label May 7, 2024
@rithviknishad rithviknishad added the Prescriptions / Medicines Related to prescriptions or medicines module. label May 7, 2024
@bodhish bodhish mentioned this issue May 8, 2024
Closed
@Sulochan-khadka
Copy link
Contributor

Is this issue solved @gigincg @bodhish or shall I raise a PR?

@gigincg
Copy link
Member Author

gigincg commented May 15, 2024

Please do @Sulochan-khadka

Sulochan-khadka added a commit to Sulochan-khadka/care_fe that referenced this issue May 16, 2024
@Sulochan-khadka
fixes: Prescriptions: Default Discontinued Prescriptions Collapsed co…
6320283 
…ronasafe#7767
@Sulochan-khadka Sulochan-khadka mentioned this issue May 16, 2024
Merged
6 tasks
@Sulochan-khadka
Copy link
Contributor

2024-05-16.21-14-30.mp4

This is the fix that the PR is aiming at. @gigincg , @rithviknishad do let me know if any changes are required further in this.

@gigincg
Copy link
Member Author

gigincg commented May 17, 2024

@Sulochan-khadka The design looks good. Please clear the issues that @rithviknishad had pointed out it so that it can be reviewed and merged

@Sulochan-khadka
Copy link
Contributor

@gigincg @rithviknishad I am not in my work place, this , do not have access to my gadgets... I urge you to go ahead for now with rest of the PRs for them to get merged... Will resume from 3rd June...

@rithviknishad rithviknishad self-assigned this May 17, 2024
@rithviknishad
Copy link
Member

Thanks for informing @Sulochan-khadka 😄

khavinshankar pushed a commit that referenced this issue May 28, 2024
@Sulochan-khadka @rithviknishad
Prescriptions: Default Discontinued Prescriptions Collapsed (#7833)
e42982e 
* fixes: Prescriptions: Default Discontinued Prescriptions Collapsed #7767

* make necessary changes and fix issues

* show medicine name when collapsed

* fix key used for list item

---------

Co-authored-by: rithviknishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

@Sulochan-khadka Sulochan-khadka

Labels
good first issue Good for newcomers Prescriptions / Medicines Related to prescriptions or medicines module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prescriptions: Default Discontinued Prescriptions Collapsed Sulochan-khadka/care_fe
3 participants
@gigincg @rithviknishad @Sulochan-khadka