Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Unauthorized Users from Accessing Facility's Patient Registration #7498

Merged
merged 27 commits into from
May 14, 2024

Conversation

AshrafMd-1
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner March 31, 2024 06:42
Copy link

vercel bot commented Mar 31, 2024

@AshrafMd-1 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5c9682f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/664252de9463130008bb8907
😎 Deploy Preview https://deploy-preview-7498--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can you check once

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

👋 Hi, @AshrafMd-1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 1bd1c43
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/660c1b3225580100082f0716

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can you remove the merge conflict

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Apr 2, 2024
Copy link

github-actions bot commented Apr 3, 2024

👋 Hi, @AshrafMd-1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 3, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 3, 2024
@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can you check once

@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@AshrafMd-1
image

  • When we click on the add patient button with a nurse user having 1 home facility and multiple linked facility, the error is thrown.

Note: Before marking it again for testing, do a QA test for self-evaluation of the PR

CC: @AshrafMd-1

@AshrafMd-1
Copy link
Contributor Author

@nihal467 my bad i did check all those edge cases but forgot to test main case

My exams will be over by tomorrow so by the end of Saturday I will submit a tested pr

@gigincg
Copy link
Member

gigincg commented May 13, 2024

@AshrafMd-1 Can you update this PR?

@AshrafMd-1
Copy link
Contributor Author

ready for testing

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fafe692 into coronasafe:develop May 14, 2024
28 of 30 checks passed
Copy link

@AshrafMd-1 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@AshrafMd-1 AshrafMd-1 deleted the Fix-#7244-1 branch May 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants