From 7a38a8af3ff74647eb62e3d9a20db2c98d23cdbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Zipitr=C3=ADa?= <3012076+fzipi@users.noreply.github.com> Date: Sun, 8 Dec 2024 15:20:32 -0300 Subject: [PATCH] Apply suggestions from code review --- nginx/Dockerfile | 1 - nginx/Dockerfile-alpine | 1 - nginx/templates/includes/cors.conf.template | 1 - 3 files changed, 3 deletions(-) diff --git a/nginx/Dockerfile b/nginx/Dockerfile index addee0b..f47213f 100644 --- a/nginx/Dockerfile +++ b/nginx/Dockerfile @@ -118,7 +118,6 @@ ENV \ CORS_HEADER_403_ALLOW_METHODS="GET, POST, PUT, DELETE, OPTIONS" \ CORS_HEADER_403_CONTENT_TYPE="text/plain" \ CORS_HEADER_403_MAX_AGE=3600 \ - CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS="*" \ DNS_SERVER= \ ERRORLOG=/var/log/nginx/error.log \ KEEPALIVE_TIMEOUT=60s \ diff --git a/nginx/Dockerfile-alpine b/nginx/Dockerfile-alpine index 0d3a3a8..65e07e6 100644 --- a/nginx/Dockerfile-alpine +++ b/nginx/Dockerfile-alpine @@ -111,7 +111,6 @@ ENV \ CORS_HEADER_403_ALLOW_METHODS="GET, POST, PUT, DELETE, OPTIONS" \ CORS_HEADER_403_CONTENT_TYPE="text/plain" \ CORS_HEADER_403_MAX_AGE=3600 \ - CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS="*" \ DNS_SERVER= \ ERRORLOG=/var/log/nginx/error.log \ KEEPALIVE_TIMEOUT=60s \ diff --git a/nginx/templates/includes/cors.conf.template b/nginx/templates/includes/cors.conf.template index 1cce89e..e0225f9 100644 --- a/nginx/templates/includes/cors.conf.template +++ b/nginx/templates/includes/cors.conf.template @@ -2,4 +2,3 @@ more_set_headers -s 403 'Content-Type' '${CORS_HEADER_403_CONTENT_TYPE}'; more_set_headers -s 403 'Access-Control-Allow-Origin' '${CORS_HEADER_403_ALLOW_ORIGIN}'; more_set_headers -s 403 'Access-Control-Max-Age' '${CORS_HEADER_403_MAX_AGE}'; more_set_headers -s 403 'Access-Control-Allow-Methods' '${CORS_HEADER_403_ALLOW_METHODS}'; -more_set_headers 'Access-Control-Allow-Headers' '${CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS}';