Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop systemd service disablement workaround #1440

Open
jlebon opened this issue Aug 9, 2022 · 1 comment
Open

Drop systemd service disablement workaround #1440

jlebon opened this issue Aug 9, 2022 · 1 comment

Comments

@jlebon
Copy link
Member

jlebon commented Aug 9, 2022

Ignition supports modifying service enablement by injecting preset files. However, disabling services hasn't worked because, until recently, systemd has been only using preset files to enable services and not disable them. As a result, we've added some code in Ignition to workaround this.

Now, systemd has made this behaviour configurable so that preset files are also used to disable systemd units, and Fedora rawhide has started to opt in. The eventual goal is to make it the default upstream.

As a result, we should be able to remove our workaround at some point. However, we need to be aware of other distributions where Ignition may rev faster than systemd. There may be also other non-Fedora-based distros which may not have opted in (but we could document that we expect them to opt in if upstream takes too long to change defaults).

@dustymabe
Copy link
Member

As a result, we should be able to remove our workaround at some point. However, we need to be aware of other distributions where Ignition may rev faster than systemd. There may be also other non-Fedora-based distros which may not have opted in (but we could document that we expect them to opt in if upstream takes too long to change defaults).

Would a compile time flag help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants