Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test_run() every time that saves a checkpoint and not in the epochs end. #41

Open
Edresson opened this issue May 10, 2022 · 4 comments

Comments

@Edresson
Copy link
Contributor

Currently, we save checkpoints without audio samples for each one. In this way, we cannot evaluate the models correctly. My suggestion is to run test_run() every time that we save a checkpoint.

@pranavpawar3
Copy link

Hi @Edresson, If you are accepting contributions, I wanted to check if I can help with implementing this feature request if not done already. I am looking to start with open source development and thought coqui would be a great platform. Please let me know. I am open to working on other feature requests as well.

@Edresson
Copy link
Contributor Author

Edresson commented Jul 7, 2022

Hi @pranavpawar3 , contributions are always welcome on all Coqui repositories. Feel free to contribute :). @erogol This feature is not already implemented and is it welcome, right?

@erogol
Copy link
Member

erogol commented Jul 7, 2022

Yep not implemented yet. Feel free to shoot a PR

@pranavpawar3
Copy link

Thanks @Edresson @erogol, I will try to make a PR soon! I shall write here if I have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants