Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AMP #136

Open
mueller91 opened this issue Dec 12, 2023 · 1 comment
Open

Remove AMP #136

mueller91 opened this issue Dec 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mueller91
Copy link

mueller91 commented Dec 12, 2023 •
edited
Loading

Describe the bug

Hi everybody,

Trainer is great, but still uses APEX, which is deprecated and tends to cause problems.
Could you remove and/or replace with Nvidia/amp?

Best regrads

image

To Reproduce

Just run Trainer on an Nvidia GPU

Expected behavior

No response

Logs

No response

Environment

not relevant

Additional context

No response
@mueller91 mueller91 added the bug Something isn't working label Dec 12, 2023
@erogol
Copy link
Member

erogol commented Dec 18, 2023 •
edited
Loading

But looks like all is put into torch natively, so yes there is no point keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erogol @mueller91