Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use tether.io for attaching absolutely positioned elements to a target #361

Closed
arpl opened this issue Dec 19, 2019 · 3 comments · Fixed by #597
Closed

Proposal: Use tether.io for attaching absolutely positioned elements to a target #361

arpl opened this issue Dec 19, 2019 · 3 comments · Fixed by #597
Assignees
Labels
proposal ready for implementation The proposal has been reviewed and approved by the maintainers

Comments

@arpl
Copy link
Contributor

arpl commented Dec 19, 2019

Hi all,

Description

There is an easy win out there called tether see docs and source. The library focuses on the very specific problem of attaching an absolutely positioned element to another.

Pros

  • Solves one problem and it does it well
  • Well maintained since major components depend on it
  • Great API and docs

Cons

  • Yet another dependency
  • Adds 5kb gzipped

Since I'm working on porting the Autocomplete we can have an example using tether which might help towards a decision.

Your awesome point of view is an absolute must ;)
Aris

@wichniowski
Copy link
Contributor

Hey @arpl I think this is a great suggestion since we previously had issues with the component that attaches and repositions dropdowns, tooltips etc.. Since tether is widely used and well tested I'd be in favor of replacing our InViewport component with it. Although it comes with a 5kb price per component package that uses it.

@sarakalinoski sarakalinoski removed their assignment Dec 20, 2019
@wichniowski wichniowski added the ready for implementation The proposal has been reviewed and approved by the maintainers label Feb 17, 2020
@kamsar
Copy link

kamsar commented Sep 30, 2020

This also causes problems with the multiple reference field editor if used in an app or UI extension (contentful/field-editors#415)

@m10l
Copy link
Contributor

m10l commented Oct 22, 2020

We recently refactored the tooltip component to use Popper.js and a follow-up PR is open to refactor the Dropdown component is currently open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal ready for implementation The proposal has been reviewed and approved by the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants