add build_with_spec(spec)

[zhujintao]

can add build method from spec?

build_with_spec(spec)

[YJDoc2]

Hey, can you add more details regarding where you want this method, and probably an example usage? Thanks.

[zhujintao]

develop a command line tool that runs independently and does not need to be used with a container runtime. spec can be customized and passed to build

 pub fn build_with_spec(self,mut spec: Spec) -> Result<Container, LibcontainerError> 

usage:

let mut spec = oci_spec::runtime::Spec::default();    //init spec
spec.set_hostname(Some("haha".to_owned()));  //config spec
...

.build_with_spec(sepc) //use build_with_spec

[YJDoc2]

You can write the created spec into the config.json file in bundle dir, and the ContainerBuilder will load it from there. Would that not work for you?

[zhujintao]

config.json file requires additional maintenance. in a single command line tool, configuring the Spec through code can be more lightweight and customized.

[zhujintao]

libcontainer is a library, don’t limit it to container runtime only.

[utam0k]

libcontainer is a library for meeting OCI Runtime Spec. From this viewpoint, config.json must be under bundler dir.
https://github.com/opencontainers/runtime-spec/blob/2d3f72ecad9e97c898e1eb04b899a51241f1cabd/bundle.md

Do you have an actual use case?

[zhujintao]

golang version
https://github.com/zhujintao/kit-go/blob/73970e15f81f75a8dbca9bae79db863dbd0f1227/runc/runc.go#L140-L151

[utam0k]

What is kit-go?