Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prow support #226

Open
saschagrunert opened this issue Sep 18, 2024 · 4 comments
Open

Add prow support #226

saschagrunert opened this issue Sep 18, 2024 · 4 comments

Comments

@saschagrunert
Copy link
Member

Are we all happy to add prow support to this project?

@cgwalters
Copy link
Contributor

Maybe? Would it run CI tests? Would it also be the merge bot?

@saschagrunert
Copy link
Member Author

@cgwalters in the first place the merge bot, we can add tests later on if we want.

@cgwalters
Copy link
Contributor

I'm not actively opposed, but nowadays GitHub has an integrated auto-merge and merge queue even functionality. Having Prow just for that IMO adds another point of failure unnecessarily.

I do know that other projects in this organization use Prow, and there is crossover between their contributors and here. But others in this organization don't.

What I personally find most valuable about Prow is being able to do Kubernetes things in CI, but we don't really need that for this project AFAIK.

@utam0k
Copy link
Member

utam0k commented Sep 23, 2024

I'm not actively opposed, but nowadays GitHub has an integrated auto-merge and merge queue even functionality. Having Prow just for that IMO adds another point of failure unnecessarily.

I do know that other projects in this organization use Prow, and there is crossover between their contributors and here. But others in this organization don't.

What I personally find most valuable about Prow is being able to do Kubernetes things in CI, but we don't really need that for this project AFAIK.

I have the same option. I don't strongly disagree, but I'd like to know why. We are used to using prow, but it isn't for new contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants