Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshotter Stat and Usage calls are likely expensive and should be cached when dealing with many objects #3027

Open
apostasie opened this issue May 22, 2024 · 0 comments

Comments

@apostasie
Copy link
Contributor

What is the problem you're trying to solve

Currently, whenever we list images (or containers), we are calling on snapshotter.Stat and snapshotter.Usage for every single layer.

This is likely a costly operation, that is also implementation dependent.

Potentially, there might be a lot of shared resources between images (eg: if they use the same base image for example).

This is related to #809 - albeit the benefits of a solution here would apply solely in cases where there is "duplication".

Describe the solution you'd like

Our suggestion is to have a caching mechanism that implements the Snapshotter interface and can be used interchangeably.

PR coming soon.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant