-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong return type in SVGPathYFromX #47
Comments
neven-s
changed the title
Wrong return value in SVGPathYFromX
Wrong return type in SVGPathYFromX
Apr 8, 2022
Hey, sorry for the late reply. It sure looks like you are right, I'll try to take a look when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
I believe there is an error on line:
react-native-slide-charts/src/lib/utils/SVGPathYFromX.ts
Line 50 in a2b8ec0
Here the return type is
DOMPoint
while definition of function says it should benumber
.I would presume the fix is adding
.y
at the end of line but I'm not sure of developers intentions.This sometimes causes my app to crash with error
Invariant Violation: [5315,"RCTView",{"top":"<<NaN>>",...}] is not usable as a native method argument
because the return value is used as
number
in calculation oftop
property such as inreact-native-slide-charts/src/lib/SlideAreaChart.tsx
Line 176 in 6daa8f7
react-native-slide-charts/src/lib/SlideAreaChart.tsx
Line 185 in 6daa8f7
The text was updated successfully, but these errors were encountered: